-
Notifications
You must be signed in to change notification settings - Fork 721
task runner actor local: resume inputs after all checkpoint… #24796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task runner actor local: resume inputs after all checkpoint… #24796
Conversation
… is sent via all outputs with multiple output channels, input channel was resumed multiple times; this could've resulted in a bug before, but after ydb-platform#22263 triggers exceptions
🟢 |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes a bug where input channels were being resumed multiple times when multiple output channels were present, causing exceptions after a related change. The fix ensures input channels are only resumed after all checkpoint data has been sent through all output channels.
- Added checkpoint tracking mechanism to count unsent checkpoints
- Replaced immediate resume calls with deferred resume logic
- Ensures input channels resume only after all outputs have sent their checkpoint data
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… is sent via all outputs
with multiple output channels, input channel was resumed multiple times; this could've resulted in a bug before, but after #22263 triggers exceptions
Changelog entry
...
Changelog category
Description for reviewers
YQ-4665
(Watermarks resumed inputs once, right after finishing with TaskRunner, no similar problem)