Skip to content

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Sep 12, 2025

… is sent via all outputs

with multiple output channels, input channel was resumed multiple times; this could've resulted in a bug before, but after #22263 triggers exceptions

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

YQ-4665
(Watermarks resumed inputs once, right after finishing with TaskRunner, no similar problem)

… is sent via all outputs

with multiple output channels, input channel was resumed multiple times;
this could've resulted in a bug before, but after ydb-platform#22263 triggers
exceptions
Copy link

github-actions bot commented Sep 12, 2025

2025-09-12 13:45:44 UTC Pre-commit check linux-x86_64-release-asan for ea80487 has started.
2025-09-12 13:45:58 UTC Artifacts will be uploaded here
2025-09-12 13:49:21 UTC ya make is running...
2025-09-12 14:14:08 UTC Check cancelled

@yumkam yumkam marked this pull request as ready for review September 12, 2025 13:45
@yumkam yumkam requested review from a team as code owners September 12, 2025 13:45
Copy link

github-actions bot commented Sep 12, 2025

🟢 2025-09-12 18:15:48 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Sep 12, 2025

2025-09-12 13:46:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for ea80487 has started.
2025-09-12 13:47:01 UTC Artifacts will be uploaded here
2025-09-12 13:51:20 UTC ya make is running...
2025-09-12 14:14:08 UTC Check cancelled

Copy link

github-actions bot commented Sep 12, 2025

2025-09-12 14:17:10 UTC Pre-commit check linux-x86_64-release-asan for f9b703f has started.
2025-09-12 14:17:14 UTC Artifacts will be uploaded here
2025-09-12 14:20:35 UTC ya make is running...
🟡 2025-09-12 16:16:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15438 15038 0 119 256 25

🟢 2025-09-12 16:17:47 UTC Build successful.
🟢 2025-09-12 16:18:09 UTC ydbd size 4.0 GiB changed* by +9.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e421060 merge: f9b703f diff diff %
ydbd size 4 321 070 776 Bytes 4 321 080 304 Bytes +9.3 KiB +0.000%
ydbd stripped size 1 494 449 624 Bytes 1 494 455 512 Bytes +5.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 12, 2025

2025-09-12 14:19:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for f9b703f has started.
2025-09-12 14:19:19 UTC Artifacts will be uploaded here
2025-09-12 14:22:48 UTC ya make is running...
🟡 2025-09-12 15:38:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38183 35423 0 4 2727 29

2025-09-12 15:42:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-12 15:52:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
227 (only retried tests) 207 0 0 0 20

🟢 2025-09-12 15:52:48 UTC Build successful.
🟢 2025-09-12 15:53:05 UTC ydbd size 2.3 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e421060 merge: f9b703f diff diff %
ydbd size 2 469 796 400 Bytes 2 469 800 560 Bytes +4.1 KiB +0.000%
ydbd stripped size 516 037 928 Bytes 516 038 952 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam requested a review from Copilot September 12, 2025 15:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a bug where input channels were being resumed multiple times when multiple output channels were present, causing exceptions after a related change. The fix ensures input channels are only resumed after all checkpoint data has been sent through all output channels.

  • Added checkpoint tracking mechanism to count unsent checkpoints
  • Replaced immediate resume calls with deferred resume logic
  • Ensures input channels resume only after all outputs have sent their checkpoint data

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yumkam yumkam changed the title task runner actor local/checkpoint: resume inputs after all checkoint… task runner actor local/checkpoint: resume inputs after all checkpoint… Sep 12, 2025
@yumkam yumkam changed the title task runner actor local/checkpoint: resume inputs after all checkpoint… task runner actor local: resume inputs after all checkpoint… Sep 12, 2025
@uzhastik uzhastik merged commit 703c893 into ydb-platform:main Sep 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants