Skip to content

25-2-1: DataShard: don't leave processed checkpoints in the buffer #24824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

25-2-1: DataShard: don't leave processed checkpoints in the buffer #24824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ydb/core/tx/datashard/memory_state_migration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ class TDataShardInMemoryRestoreActor
Buffer.Insert(Buffer.End(), std::move(payload));
}

// We must not have any checkpoints in the buffer yet
Y_ENSURE(Checkpoints.empty());

size_t lastOffset = 0;
for (size_t offset : msg->Record.GetSerializedStateCheckpoints()) {
// These offsets are relative to the start of the new chunk, we make
Expand Down Expand Up @@ -208,6 +211,8 @@ class TDataShardInMemoryRestoreActor
Arena.Reset();
}

Checkpoints.clear();

if (msg->Record.HasContinuationToken()) {
// Request the next data chunk
// Note: we have subscribed in the first request already
Expand Down
Loading