For names replace enum fields values symbols to abbreviations

[uldisn]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	[(https://github.com//issues/557)]

[schmunk42]

This breaks BC to my understanding!

What you could do is moving constantName to a callback with the current function as a default.

[samdark]

Need a line for CHANGELOG.

[samdark]

Suggested change

	const SYMBOLS_ABBREVIATION = [
	const SYMBOLS_ABBREVIATION = [

[schmunk42]

@samdark This needs rework, IMHO it is not BC.

Test have to cover the current behavior eg. "B+" and "B-" leading to the same constant.
What is about "A-Foo", "A-Bar"?

And a test for the new behavior when setting the constantNameCallback in the class.

CC: @rob006

[uldisn]

And a test for the new behavior when setting the constantNameCallback in the class.
I didn't understand.

[samdark]

@schmunk42 is it better now?

[schmunk42]

@schmunk42 is it better now?

No, I don't see my points addresses.
First, there should be tests covering the current functionality.

[uldisn]

@samdark all generated code is covered

[schmunk42]

Still breaks BC.

This line should read:

$constantName = $this->constantNameCallback($column->name, $value)

This is the public property

public $constantNameCallback = function($name, $value){
  return strtoupper(Inflector::slug($name . ' ' . $value, '_'));
}

Somehow like that... I haven't tested it.

With this you should be able to plug-in any constant name generator function you want.

[uldisn]

@schmunk42

[schmunk42]

Honestly, this is a huge change, I can not tell if it is BC or not.
Also I am currently in holidays and have no time to review it.

I am against it, sorry.

[uldisn]

?

[schmunk42]

So, to my understanding here's some magic, which handles stuff like A-Foo the way it was.

https://github.com/yiisoft/yii2-gii/pull/556/files#diff-58ec64246f814497eb0524bc73fc58181b344edc0651e9e1014b004ee012554aR127-R145

But if you have something like A (1):

• current code: A_1
• PR code: A_OPENING_PARENTHESIS_1_CLOSING_PARENTHESIS

correct?

As mentioned before, it's too opinionated IMHO and an approach with a simple callback would be the best:
#556 (comment)