Skip to content

Conversation

max-s-lab
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #20489

@max-s-lab max-s-lab marked this pull request as draft August 23, 2025 11:14
@max-s-lab max-s-lab changed the title Replace deprecated strftime with date Replace deprecated strftime with date in YiiRequirementChecker Aug 23, 2025
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.47%. Comparing base (22889d3) to head (b4c5e33).

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20498   +/-   ##
=========================================
  Coverage     64.47%   64.47%           
  Complexity    11578    11578           
=========================================
  Files           433      433           
  Lines         37604    37604           
=========================================
  Hits          24245    24245           
  Misses        13359    13359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@terabytesoftw
Copy link
Member

It would be great to replace it everywhere in another PR.

@max-s-lab
Copy link
Contributor Author

It seems that this is the only place where the PHP function strftime is used. In other places, strftime is an SQLite function. I may be wrong, but this is how I understand it.

@max-s-lab max-s-lab marked this pull request as ready for review August 23, 2025 11:34
@terabytesoftw
Copy link
Member

It seems that this is the only place where the PHP function strftime is used. In other places, strftime is an SQLite function. I may be wrong, but this is how I understand it.

yes, it is correct.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants