-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(host-contracts): cleanup ACL #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore(coprocessor): fix typo
isaacdecoded
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why these changes are needed right now. Also, this will have lot of conflicts with the ongoing PR for delegated decryption 🤔
coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs
Show resolved
Hide resolved
Yes we need it if we decide to redeploy contracts. Conflicts are minimal in this case with my PR, ill update it later. |
isaacdecoded
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the point of this PR of taking the chance for removing potential to-be-deprecated state. Maybe we should notify coprocessor team about the change in the host-listener service.
melanciani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !
* feat(host-contracts): cleanup ACL * chore(host-contracts): updated tests and selectors * chore(coprocessor): removed deprecated events chore(coprocessor): fix typo * chore(host-contracts): update readme
* feat(gateway-contracts): remove useless url storing and cleanup (#1034) * feat(gateway-contracts): remove useless url storing and cleanup * chore(gateway-contracts): fixed typos * test(gateway-contracts): removed some of the deprecated tests * chore(gateway-contracts): fixed getters * chore(gateway-contracts): conformance chore(gateway-contracts): conformance check * feat(host-contracts): cleanup ACL (#1036) * feat(host-contracts): cleanup ACL * chore(host-contracts): updated tests and selectors * chore(coprocessor): removed deprecated events chore(coprocessor): fix typo * chore(host-contracts): update readme * feat(kms-connector): re-estimate gas on out-of-gas failed tx and resend (#1037) * feat(kms-connector): retry on out-of-gas * chore(kms-connector): quickfix to update gas on kmsgeneration contract * chore(kms-connector): cargo linting * chore(kms-connector): remove useless code
* feat(host-contracts): cleanup ACL * chore(host-contracts): updated tests and selectors * chore(coprocessor): removed deprecated events chore(coprocessor): fix typo * chore(host-contracts): update readme
No description provided.