Documentation (comments) only #5
Merged
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LarryRuane
commented
Nov 5, 2025
LarryRuane
commented
- GetBlockRange: high-to-low range returns blocks in high-to-low order
- CompactBlock: describe header field accurately (full header)
- add blank lines for readability
- GetBlockRange: high-to-low range returns blocks in high to low order - CompactBlock: describe header field accurately (full header) - add blank lines for readability
nuttycom
reviewed
Nov 7, 2025
daira
reviewed
Nov 9, 2025
| rpc GetBlockNullifiers(BlockID) returns (CompactBlock) {} | ||
| // Return a list of consecutive compact blocks | ||
|
|
||
| // Return a list of consecutive compact blocks in the specified range. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Return a list of consecutive compact blocks in the specified range. | |
| // Return a list of consecutive compact blocks in the specified range, | |
| // which is inclusive of `range.end`. |
Contributor
There was a problem hiding this comment.
I included this in https://github.com/zcash/lightwallet-protocol/pull/7/files
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.