ui: Wire up tab indices within buttons #35368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
MrSubidubi
force-pushed
the
tab-index-buttons
branch
from
0de64f3 to
5441e39
Compare
probably-neb
force-pushed
the
tab-index-buttons
branch
from
5441e39 to
25d6c48
Compare
Collaborator
orual
pushed a commit
to orual/zed
that referenced
this pull request
Aug 23, 2025
This change adds the current tab index functionality to buttons and implements a proof of concept for the new welcome page. Primarily blocked on zed-industries#34804, secondarily on zed-industries#35075 so we can ensure navigation always works as intended. Another thing to consider here is whether we want to assign the tab order more implicitly / "automatically" based on the current layout ordering. This would generally enable us to add a default order to focusable elements if we want this. See [the specification](https://html.spec.whatwg.org/multipage/interaction.html#flattened-tabindex-ordered-focus-navigation-scope) on some more context on how the web usually handles this for focusable elements. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the current tab index functionality to buttons and implements a proof of concept for the new welcome page.
Primarily blocked on #34804, secondarily on #35075 so we can ensure navigation always works as intended.
Another thing to consider here is whether we want to assign the tab order more implicitly / "automatically" based on the current layout ordering. This would generally enable us to add a default order to focusable elements if we want this. See the specification on some more context on how the web usually handles this for focusable elements.
Release Notes: