gpui: Add support for super ellipse corner rendering #41232
+437
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for squircle (superellipse) corner rendering
to GPUI elements using GPU-accelerated signed distance field (SDF)
calculations.
Key features:
- New `.smoothness()` method on all styled elements (div, img, etc.)
- Smoothness parameter: 0.0 (circle) to 0.5 (squircle) to 1.0 (square)
- GPU-based SDF rendering for high performance
- Cross-platform: WGSL (Linux), Metal (macOS), HLSL (Windows)
- Fully backward compatible (defaults to 0.0)
Implementation:
- Extended Style struct with optional smoothness field
- Added smoothness to PaintQuad for quad rendering
- Updated all three shader backends to use squircle_sdf() when
smoothness > 0.0
- Reuses existing squircle SDF infrastructure from sprite rendering
- Proper struct alignment (168 bytes) for GPU compatibility
Usage:
```rust
div()
.rounded(px(40.0))
.smoothness(0.5) // Squircle corners
.bg(red())
img(path)
.rounded(px(50.0))
.smoothness(0.5)
```
|
We require contributors to sign our Contributor License Agreement, and we don't have @ahkohd on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
maxdeviant
changed the title
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @ahkohd on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for squircle (superellipse) corner rendering to GPUI elements using GPU-accelerated signed distance field (SDF) calculations.
Key features:
.smoothness()method on all styled elements (div, img, etc.)Implementation:
Usage:
Demo:
Linux/Wayland - WGSL demo
macOS - Metal demo
Windows - HLSL demo
Testing:
Release Notes: