This repository was archived by the owner on Nov 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Add support for ephemeral SSH keys via EC2 Instance Connect #17
Open
zytek
wants to merge
6
commits into
zendesk:master
Choose a base branch
from
zytek:ec2-connect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ability to use ephemeral SSH keys for connecting to EC2 instances Check this for more details: https://aws.amazon.com/blogs/compute/new-using-amazon-ec2-instance-connect-for-ssh-access-to-your-ec2-instances/ * add new command push-key: helper command that can be executed for example as a local action in ansible before running playbooks * add default provider config to `goship configure` for easier user onboarding
If we are pushing specific SSH key to EC2 metadata we should also provide private key in ssh subcommands in case user does not have given key in ssh key agent
emate
suggested changes
Apr 14, 2020
emate
suggested changes
Apr 14, 2020
Contributor
emate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Awesome work!
Contributor
Author
|
@emate your comments addressed 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ability to use ephemeral SSH keys for connecting to EC2 instances
Check this for more details: https://aws.amazon.com/blogs/compute/new-using-amazon-ec2-instance-connect-for-ssh-access-to-your-ec2-instances/
add new command push-key: helper command that can be executed
for example as a local action in ansible before running playbooks
add default provider config to
goship configurefor easieruser onboarding