Skip to content

Conversation

@bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Oct 30, 2025

This is quite a large PR, so I would advise you to read the whole description before starting the review.

What did we capture? vs What do we capture now?

Previously, ZenML used to add a new handler to the root logger. This root logger was used to capture all the logs that goes through the root logger and store them in the artifact store. Additionally, we used to wrap the built-in print function in a way, that we stored the printed messages as well. However, in this case, we missed on a couple of sources such as messages from loggers that do not propagate to the root logger, anything on the stdout/stderr aside from log messages and print statements.

OpenTelemetry

Managing the dependency

Implementation of a new component

Local execution

Thread security

Various other changes

  • There was a context variable called redirected which was defaulted to False and never used afterwards. That is now removed.

TODOs

  • Add the dependency to the pyproject.toml
  • Test it remote
  • Write docs
  • Write tests
  • The step launcher used to trigger a merge before starting the step on the step operators. Fix that.
  • Think about adding the entity type and id in the model and schemas.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • IMPORTANT: I made sure that my changes are reflected properly in the following resources:
    • ZenML Docs
    • Dashboard: Needs to be communicated to the frontend team.
    • Templates: Might need adjustments (that are not reflected in the template tests) in case of non-breaking changes and deprecations.
    • Projects: Depending on the version dependencies, different projects might get affected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@bcdurak bcdurak changed the base branch from main to develop October 30, 2025 10:03
@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request internal To filter out internal PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants