-
Notifications
You must be signed in to change notification settings - Fork 551
Document ZenML Pro Personal Access Tokens and deprecate API tokens #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
✅ No broken links found! |
htahir1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment for now. Also can you give me the final URL that i can use in the dashboard? i need something to link from the zenml cloud dashboard to the docs page that described the PAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation Link Check Results❌ Absolute links check failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some changes and left you some screenshots you can use
docs/book/how-to/manage-zenml-server/connecting-to-zenml/README.md
Outdated
Show resolved
Hide resolved
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 25.5%, saving 44.79 KB.
380 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
|
@htahir1 I applied all your suggestions, please take a look here: https://zenml-io.gitbook.io/stefan/ |
htahir1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks way better now - Just two things:
a) I think you are inferring the URLs wrongly. Best way is to map them to your preview so https://zenml-io.gitbook.io/stefan/zenml-pro/access-management/personal-access-tokens will be https://docs.zenml.io/pro/access-management/personal-access-tokens (Note that in your space its /zenml-pro/ but in the real space it will be /pro/)
b) You have not added redirects as I asked in the .gitbook.yaml ;-) Reminder :-)
|
|
||
| # Connect with a Personal Access Token | ||
|
|
||
| If you are using ZenML Pro and need to call the ZenML Pro workspace API from a non-interactive environment, you also have the option of creating and using a Personal Access Token. Personal Access Tokens are scoped to your ZenML Pro user account and can be used to access all workspaces you are a member of in any organization. See the [ZenML Pro Personal Access Tokens](https://docs.zenml.io/pro/core-concepts/personal-access-tokens) documentation for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be the URL? https://docs.zenml.io/pro/core-concepts/personal-access-tokens, in your preview I see https://zenml-io.gitbook.io/stefan/zenml-pro/access-management/personal-access-tokens
| ``` | ||
|
|
||
| If you're using a ZenML Pro server, you will need to create an organization-level service account and an API key for it. You can find more about organization-level service accounts and API keys [here](https://docs.zenml.io/pro/core-concepts/service-accounts). | ||
| If you're using a ZenML Pro server, you will need to create a Personal Access Token or an organization-level service account and an API key for it. You can find more about Personal Access Tokens [here](https://docs.zenml.io/pro/core-concepts/personal-access-tokens) and organization-level service accounts and API keys [here](https://docs.zenml.io/pro/core-concepts/service-accounts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
|
|
||
| If you're using a ZenML Pro server, you will need to create an organization-level service account and an API key for it. You can find more about organization-level service accounts and API keys [here](https://docs.zenml.io/pro/core-concepts/service-accounts). | ||
| If you're using a ZenML Pro server, you will need to create a Personal Access Token or an organization-level service account and an API key for it. You can find more about Personal Access Tokens [here](https://docs.zenml.io/pro/core-concepts/personal-access-tokens) and organization-level service accounts and API keys [here](https://docs.zenml.io/pro/core-concepts/service-accounts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…nml into feature/deprecate-api-tokens
ZenML CLI Performance Comparison (Threshold: 1.0s, Timeout: 60s, Slow: 5s)❌ Failed Commands on Current Branch (feature/deprecate-api-tokens)
🚨 New Failures IntroducedThe following commands fail on your branch but worked on the target branch:
Performance Comparison
Summary
Environment Info
|


Describe changes
Document ZenML Pro Personal Access Tokens and deprecate API tokens.
This PR also removes the recently introduced
zenml tokenCLI command.Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes