Skip to content

Fixes findDOMNode errors for react 18 #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes findDOMNode errors for react 18 #980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ React-Quill
https://github.com/zenoamaro/react-quill
*/

import React from 'react';
import ReactDOM from 'react-dom';
import React, { createRef } from 'react';
import isEqual from 'lodash/isEqual';

import Quill, {
Expand Down Expand Up @@ -90,6 +89,7 @@ interface ReactQuillState {
}

class ReactQuill extends React.Component<ReactQuillProps, ReactQuillState> {
editingAreaRef = createRef<any>()

static displayName = 'React Quill'

Expand Down Expand Up @@ -433,10 +433,10 @@ class ReactQuill extends React.Component<ReactQuillProps, ReactQuillState> {
}

getEditingArea(): Element {
if (!this.editingArea) {
if (!this.editingAreaRef.current) {
throw new Error('Instantiating on missing editing area');
}
const element = ReactDOM.findDOMNode(this.editingArea);
const element = this.editingAreaRef.current;
if (!element) {
throw new Error('Cannot find element for editing area');
}
Expand All @@ -455,9 +455,7 @@ class ReactQuill extends React.Component<ReactQuillProps, ReactQuillState> {

const properties = {
key: generation,
ref: (instance: React.ReactInstance | null) => {
this.editingArea = instance
},
ref: this.editingAreaRef,
};

if (React.Children.count(children)) {
Expand Down