drivers: mcpwm: esp32: Fix duty rounding #94880
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: ESP32
zephyrbot
requested review from
anangl,
henrikbrixandersen,
LucasTambor,
marekmatej,
sylvioalves,
uLipe and
wmrsouza
sylvioalves
approved these changes
Aug 22, 2025
wmrsouza
approved these changes
Aug 22, 2025
Duty value in the driver is calculated from timer cycles, which can introduce precision loss when converting from pwm_set() to pwm_set_cycles(). To avoid truncating values with a fractional part ≥ 0.5 and further drifting the effective duty, round the computed duty to the nearest integer. Signed-off-by: Raffael Rostagno <[email protected]>
raffarost
force-pushed
the
fix/mcpwm_duty
branch
from
bb79939 to
edc0c1b
Compare
|
uLipe
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duty value in the driver is calculated from timer cycles, which can introduce precision loss when converting from pwm_set() to pwm_set_cycles(). To avoid truncating values with a fractional part ≥ 0.5 and further drifting the effective duty, round the computed duty to the nearest integer.