twister: use csv to split extra argument arguments for west flags #94883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently twister requires west to flash a board, either directly using west-flash or indirectly through the cmake flash target. Add an option to specify a custom flash script, this is passed a build-dir and board-id flags so it can be used to implement custom flashing scripts in a system that does not use west. Signed-off-by: Fabio Baltieri <[email protected]>
Add the necessary logic to pass the custom flash_command to the pytest harness. Signed-off-by: Fabio Baltieri <[email protected]>
Use csv instead of a plain split to split extra arguments for extra west flags, this allows correct passing of arguments that are internally escaped in quotes, such as arugments containing commas. Signed-off-by: Fabio Baltieri <[email protected]>
|
|
Considering how small is the last commit, the git conflict with #93944 cannot be big. I would let these two race each other but you do you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use csv instead of a plain split to split extra arguments for extra west flags, this allows correct passing of arguments that are internally escaped in quotes, such as arugments containing commas.
Deps: