feat: add support for separate key pairs password in SSL configuration #3577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add keyPairsPassword parameter to SSL configurations - Allow different passwords for keystore and key pairs - Update ClientSSLConverter and ServerSSLDecoder to handle separate passwords - Maintain backward compatibility by falling back to keystore password if key pairs password not specified - Add configuration support for keyPairsPassword in both client and server SSL configs
therealcisse
requested review from
987Nabil,
jdegoes,
kyri-petrou and
vigoo
as code owners
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for specifying a separate password for key pairs within the keystore, which is useful when the keystore password and the private key password differ.
Changes
keyPairsPasswordparameter to SSL configurationsClientSSLConverterandServerSSLDecoderto handle separate passwords for keystore and key pairskeyPairsPasswordin both client and server SSL configsMotivation
In some SSL/TLS configurations, the keystore password (used to access the keystore) can be different from the password protecting the private keys within the keystore. This is a common security practice. Previously, zio-http assumed both passwords were the same, which limited compatibility with certain keystore configurations.
Backward Compatibility
This change is fully backward compatible. If
keyPairsPasswordis not specified, it will fall back to using thekeyManagerPasswordas before.