This repository was archived by the owner on Apr 14, 2018. It is now read-only.
Marisa Morris - Carets #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marisamorris
changed the title
|
Hey Marisa, I've reviewed your Media Ranker OAuth project and I have a bit of feedback. The good:
So you have the basics down. Things to work on:
I'm guessing you ran out of some time here. So not bad, but there was more to work though. In what little we have left of Rails and the classroom content, more practice with testing would be valuable. |
CheezItMan
reviewed
Nov 5, 2017
| # We should always be able to tell what category | ||
| # of work we're dealing with | ||
| before_action :category_from_work, except: [:root, :index, :new, :create] | ||
| skip_before_action :find_user, only: [:root] |
There was a problem hiding this comment.
By avoiding this filter it shows a log in button on the homepage, even after I'm logged in. You can add a different bit of ocood to the root path to find the user. Or create 2 filters, one to find the user and another to redirect if it's not there.
| <!-- --------------------------------- --> | ||
| <div class="float-right"> | ||
| <!-- T0DO --> | ||
| <%= @login_user %> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.