Skip to content
This repository was archived by the owner on Apr 14, 2018. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# or operating system, you probably want to add a global ignore instead:
# git config --global core.excludesfile '~/.gitignore_global'

.env

# Ignore bundler config.
/.bundle

Expand Down
9 changes: 8 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
source 'https://rubygems.org'

ruby '2.4.0'
ruby '2.4.1'

git_source(:github) do |repo_name|
repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
"https://github.com/#{repo_name}.git"
end


gem 'awesome_print'
gem "omniauth"
gem "omniauth-github"


# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '~> 5.0.2'
# Use postgresql as the database for Active Record
Expand Down Expand Up @@ -48,6 +54,7 @@ group :development, :test do

# Use pry for rails console
gem 'pry-rails'
gem 'dotenv-rails'
end

group :test do
Expand Down
34 changes: 32 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ GEM
tzinfo (~> 1.1)
ansi (1.5.0)
arel (7.1.4)
awesome_print (1.8.0)
babel-source (5.8.35)
babel-transpiler (0.7.0)
babel-source (>= 4.0, < 6)
Expand All @@ -60,15 +61,22 @@ GEM
execjs
coffee-script-source (1.12.2)
concurrent-ruby (1.0.5)
dotenv (2.2.1)
dotenv-rails (2.2.1)
dotenv (= 2.2.1)
railties (>= 3.2, < 5.2)
erubis (2.7.0)
execjs (2.7.0)
faraday (0.12.2)
multipart-post (>= 1.2, < 3)
ffi (1.9.18)
foundation-rails (6.3.0.0)
railties (>= 3.1.0)
sass (>= 3.3.0, < 3.5)
sprockets-es6 (>= 0.9.0)
globalid (0.3.7)
activesupport (>= 4.1.0)
hashie (3.5.6)
i18n (0.8.1)
jbuilder (2.6.3)
activesupport (>= 3.0.0, < 5.2)
Expand All @@ -77,6 +85,7 @@ GEM
rails-dom-testing (>= 1, < 3)
railties (>= 4.2.0)
thor (>= 0.14, < 2.0)
jwt (1.5.6)
listen (3.0.8)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
Expand Down Expand Up @@ -104,9 +113,26 @@ GEM
minitest (~> 5.0)
rails (>= 4.1)
multi_json (1.12.1)
multi_xml (0.6.0)
multipart-post (2.0.0)
nio4r (2.0.0)
nokogiri (1.7.1)
mini_portile2 (~> 2.1.0)
oauth2 (1.4.0)
faraday (>= 0.8, < 0.13)
jwt (~> 1.0)
multi_json (~> 1.3)
multi_xml (~> 0.5)
rack (>= 1.2, < 3)
omniauth (1.7.1)
hashie (>= 3.4.6, < 3.6.0)
rack (>= 1.6.2, < 3)
omniauth-github (1.3.0)
omniauth (~> 1.5)
omniauth-oauth2 (>= 1.4.0, < 2.0)
omniauth-oauth2 (1.4.0)
oauth2 (~> 1.0)
omniauth (~> 1.2)
pg (0.20.0)
pry (0.10.4)
coderay (~> 1.1.0)
Expand Down Expand Up @@ -193,9 +219,11 @@ PLATFORMS
ruby

DEPENDENCIES
awesome_print
better_errors
byebug
coffee-rails (~> 4.2)
dotenv-rails
foundation-rails
jbuilder (~> 2.5)
jquery-rails
Expand All @@ -204,6 +232,8 @@ DEPENDENCIES
minitest-reporters
minitest-skip
minitest-spec-rails
omniauth
omniauth-github
pg (~> 0.18)
pry-rails
puma (~> 3.0)
Expand All @@ -217,7 +247,7 @@ DEPENDENCIES
web-console (>= 3.3.0)

RUBY VERSION
ruby 2.4.0p0
ruby 2.4.1p111

BUNDLED WITH
1.14.4
1.15.4
19 changes: 18 additions & 1 deletion app/controllers/application_controller.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
class ApplicationController < ActionController::Base
protect_from_forgery with: :exception

# helper_method :find_user
before_action :find_user
before_action :require_login, except: [:root]


def render_404
# DPR: supposedly this will actually render a 404 page in production
Expand All @@ -11,7 +14,21 @@ def render_404
private
def find_user
if session[:user_id]
@login_user = User.find_by(id: session[:user_id])
@login_user ||= User.find_by(id: session[:user_id])
else
flash[:status] = :failure
flash[:result_text] = "Please Log In :)"
redirect_to root_path
end
end


def require_login
if @login_user == nil
flash[:status] = :failure
flash[:result_text] = "Please Log In :)"
redirect_to root_path
end
end

end
28 changes: 28 additions & 0 deletions app/controllers/sessions_controller.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
class SessionsController < ApplicationController

skip_before_action :find_user
skip_before_action :require_login

def login_form
end

Expand Down Expand Up @@ -31,4 +35,28 @@ def logout
flash[:result_text] = "Successfully logged out"
redirect_to root_path
end


def create
# ap @auth_hash
@auth_hash = request.env['omniauth.auth']
@user = User.find_by(uid: @auth_hash['uid'], provider: @auth_hash['provider'])

if @user
session[:user_id] = @user.id
flash[:success] = "Welcome #{@user.username}"
else
@user = User.new uid: @auth_hash['uid'], provider: @auth_hash['provider'], username: @auth_hash['info']['nickname'], email:@auth_hash['info']['email']
end

if @user.save
session[:user_id] = @user.id
flash[:success] = "#{@user.username} is logged in"
else
flash[:error] = "unable to log in"
end
redirect_to root_path
end


end
13 changes: 13 additions & 0 deletions app/controllers/users_controller.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,23 @@
class UsersController < ApplicationController
def index
@users = User.all
flash[:success]
redirect_to users_path
end

def show
@user = User.find_by(id: params[:id])
flash[:success]

render_404 unless @user
end

def destroy_all
@users = User.all
@votes = Vote.all

@users.destroy
@votes.destroy
redirect_to users_path
end
end
2 changes: 2 additions & 0 deletions app/controllers/works_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ class WorksController < ApplicationController
# We should always be able to tell what category
# of work we're dealing with
before_action :category_from_work, except: [:root, :index, :new, :create]
skip_before_action :find_user, only: [:root]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By avoiding this filter it shows a log in button on the homepage, even after I'm logged in. You can add a different bit of ocood to the root path to find the user. Or create 2 filters, one to find the user and another to redirect if it's not there.


def root
@albums = Work.best_albums
Expand All @@ -20,6 +21,7 @@ def new

def create
@work = Work.new(media_params)
@work.user = @login_user
@media_category = @work.category
if @work.save
flash[:status] = :success
Expand Down
1 change: 1 addition & 0 deletions app/models/user.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
class User < ApplicationRecord
has_many :votes
has_many :works
has_many :ranked_works, through: :votes, source: :work

validates :username, uniqueness: true, presence: true
Expand Down
1 change: 1 addition & 0 deletions app/models/work.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ class Work < ApplicationRecord
CATEGORIES = %w(album book movie)
has_many :votes, dependent: :destroy
has_many :ranking_users, through: :votes, source: :user
belongs_to :user

validates :category, presence: true,
inclusion: { in: CATEGORIES }
Expand Down
24 changes: 18 additions & 6 deletions app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,30 @@
<small>Ranking the Best of Everything</small>
</h2>


<nav class="columns small-12">
<%= link_to "View top media", root_path, class: "button" %>
<%= link_to "View all media", works_path, class: "button" %>
<%= link_to "Add a new work", new_work_path, class: "button" %>
<%= link_to "View all users", users_path, class: "button" %>

<!-- <%# if @login_user %> -->
<%= link_to "View top media", root_path, class: "button" %>
<%= link_to "View all media", works_path, class: "button" %>
<%= link_to "Add a new work", new_work_path, class: "button" %>
<%= link_to "View all users", users_path, class: "button" %>
<!-- <%# end %> -->

<!-- --------------------------------- -->
<div class="float-right">
<!-- T0DO -->
<%= @login_user %>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something to remove.

<!-- nothing is being passed -->

<% if @login_user %>
<%= link_to "Logged in as #{@login_user.username}", user_path(@login_user), class: "button" %>
<%# link_to "Logged in as #{@login_user.username}", user_path(@login_user), class: "button" %>
<%= link_to "Log Out", logout_path, method: :post, class: "button" %>
<% else %>
<%= link_to "Log In", login_path, class: "button float-right" %>
<%= link_to "Log In", "/auth/github", class: "button float-right" %>
<% end %>
<!-- --------------------------------- -->

</div>
</nav>
</header>
Expand Down
2 changes: 2 additions & 0 deletions app/views/sessions/login_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<%= submit_tag("Log In", class: "button") %>
<% end %>



<article>
<h4>A note about logging in</h4>
<p>
Expand Down
17 changes: 13 additions & 4 deletions app/views/works/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,19 @@
<p>Published: <%= @work.publication_year %></p>
<p><%= @work.description %></p>
<section>
<%= link_to "Back to media ranks", root_path, class: "button" %>
<%= link_to "Edit", edit_work_path(@work), class: "button" %>
<%= link_to "Upvote", upvote_path(@work), class: "button", method: :post %>
<%= link_to "Delete", work_path(@work), class: "alert button", method: "delete", data: { confirm: "Are you sure?" } %>

<%= link_to "Back to media ranks", root_path, class: "button" %>

<% if @login_user == @work.user %>
<%= link_to "Edit", edit_work_path(@work), class: "button" %>
<% end %>

<%= link_to "Upvote", upvote_path(@work), class: "button", method: :post %>

<% if @login_user == @work.user %>
<%= link_to "Delete", work_path(@work), class: "alert button", method: "delete", data: { confirm: "Are you sure?" } %>
<% end %>

</section>
</article>

Expand Down
3 changes: 3 additions & 0 deletions config/initializers/omniauth.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Rails.application.config.middleware.use OmniAuth::Builder do
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email"
end
2 changes: 2 additions & 0 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@
post '/works/:id/upvote', to: 'works#upvote', as: 'upvote'

resources :users, only: [:index, :show]

get "/auth/:provider/callback", to: "sessions#create", as: 'auth_callback'
end
7 changes: 7 additions & 0 deletions db/migrate/20171016225133_add_columns_to_users.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class AddColumnsToUsers < ActiveRecord::Migration[5.0]
def change
add_column :users, :email, :string
add_column :users, :uid, :integer
add_column :users, :provider, :string
end
end
6 changes: 6 additions & 0 deletions db/migrate/20171016230611_null_columns_in_users_table.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class NullColumnsInUsersTable < ActiveRecord::Migration[5.0]
def change
change_column_null(:users, :uid, false)
change_column_null(:users, :provider, false)
end
end
7 changes: 7 additions & 0 deletions db/migrate/20171017004546_create_relationships.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class CreateRelationships < ActiveRecord::Migration[5.0]
def change
add_column :works, :user_id, :integer
add_foreign_key :works, :users
end

end
7 changes: 6 additions & 1 deletion db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20170407164321) do
ActiveRecord::Schema.define(version: 20171017004546) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand All @@ -19,6 +19,9 @@
t.string "username"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.string "email"
t.integer "uid", null: false
t.string "provider", null: false
end

create_table "votes", force: :cascade do |t|
Expand All @@ -39,8 +42,10 @@
t.datetime "updated_at", null: false
t.integer "vote_count", default: 0
t.integer "publication_year"
t.integer "user_id"
end

add_foreign_key "votes", "users"
add_foreign_key "votes", "works"
add_foreign_key "works", "users"
end
Loading