tests: add backup reminder banner test. #3666
Conversation
|
|
||
| // First, clean up cache and headers. | ||
| try { | ||
| const basePath = path.resolve(__dirname, '../../../../appfolder.dev/cache'); |
There was a problem hiding this comment.
Would it help to use nodejs built in process.cwd() function here instead of traversing up the directory structure?
There was a problem hiding this comment.
IIRC I tried but since we launch the tests from frontends/web, process.cwd() resolves to that dir. However I just slightly refactored it to be much cleaner in github CI (and moderately cleaner in non-CI :D )
There was a problem hiding this comment.
ah I see, no strong opinion. It was more a question.
I guess the Makefile task starts from the root, but then cd into frontends/web
Line 66 in 43b29d9
|
|
||
| const { stdout } = await execAsync(cmd); | ||
| return stdout.trim(); | ||
| } |
There was a problem hiding this comment.
I don't understand engouh docker and am always confused about when to use spawn, fork or exec.
It looks very cool what you do in this file with the regtest, but I am not the right person to review this.
There was a problem hiding this comment.
Thanks, I will revisit this file, add some comments, and ask for another reviewer :)
bznein
force-pushed
the
regtest
branch
8 times, most recently
from
fa11eee to
62f6f60
Compare
This was accidentally changed in 21ebd32
2 participants
Also solves a few flakiness issues and reverts an accidental change.
Before asking for reviews, here is a check list of the most common things you might need to consider: