Switch to random walk based on prior specification #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than test for strict equality, test for expected properties. This approach is more robust to changes in the model over time because it looks for the type and properties of output. We don't expect the exact diagnostic flags to remain the same in all settings.
This change allows us to switch between the GP and the random walk options based on the priors specified in the config. It errors if priors for both the GP and the RW are supplied. It still needs test coverage and a change in the config generator to actually supply the needed values.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thank you for your contribution @micahwiesner67 🚀! Your pkgdown-site is ready for download 👉 here 👈! |
micahwiesner67
temporarily deployed
to
production
GitHub Actions
Inactive
micahwiesner67
temporarily deployed
to
production
GitHub Actions
Inactive
micahwiesner67
temporarily deployed
to
production
GitHub Actions
Inactive
micahwiesner67
temporarily deployed
to
production
GitHub Actions
Inactive
micahwiesner67
temporarily deployed
to
production
GitHub Actions
Inactive
micahwiesner67
temporarily deployed
to
production
GitHub Actions
Inactive
micahwiesner67
had a problem deploying
to
production
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to switch between the GP and the random walk
options based on the priors specified in the config. It errors if priors
for both the GP and the RW are supplied.
It still needs test coverage and a change in the config generator to
actually supply the needed values.
While I was in here, I fixed the broken diagnostic test.
Closes #315