fix: fix the nosign policy validation wrong check #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Kai <[email protected]>
GrapeBaBa
changed the title
wemeetagain
reviewed
Sep 12, 2025
| case StrictNoSign: | ||
| if (msg.signature != null) return { valid: false, error: ValidateError.SignaturePresent } | ||
| if (msg.seqno != null) return { valid: false, error: ValidateError.SeqnoPresent } | ||
| if (msg.key != null) return { valid: false, error: ValidateError.FromPresent } |
There was a problem hiding this comment.
I suppose we also want to keep the validation that msg.key is not present (with a ValidateError.KeyPresent error)
There was a problem hiding this comment.
If there is indeed such a rule, I would like to add it. The original code is consistent with the implementation of rust, and the implementation of rust does not check the key.
wemeetagain
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small fix in the
validateToRawMessagefunction to correctly check the presence of thefromfield instead of thekeyfield when validating messages with theStrictNoSignoption. This improves the accuracy of validation error reporting.