Skip to content

fix: fix the nosign policy validation wrong check #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix: fix the nosign policy validation wrong check #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/buildRawMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export async function validateToRawMessage (
case StrictNoSign:
if (msg.signature != null) return { valid: false, error: ValidateError.SignaturePresent }
if (msg.seqno != null) return { valid: false, error: ValidateError.SeqnoPresent }
if (msg.key != null) return { valid: false, error: ValidateError.FromPresent }
Copy link
Member

@wemeetagain wemeetagain Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we also want to keep the validation that msg.key is not present (with a ValidateError.KeyPresent error)

Copy link
Contributor Author

@GrapeBaBa GrapeBaBa Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is indeed such a rule, I would like to add it. The original code is consistent with the implementation of rust, and the implementation of rust does not check the key.

if (msg.from != null) return { valid: false, error: ValidateError.FromPresent }

return { valid: true, message: { type: 'unsigned', topic: msg.topic, data: msg.data ?? new Uint8Array(0) } }

Expand Down
Loading