Skip to content

Conversation

@mwhit030
Copy link
Contributor

@mwhit030 mwhit030 commented Sep 4, 2025

Summary

Content "Add vertical milling machines"

Purpose of change

Adds manual milling machines, rectangular bar stock, a machinist background, and a practice recipe to the game.

Describe the solution

Create an appliance and add related items and recipes.

Describe alternatives you've considered

seperating the machining proficiency into ones for the lathe/mill, or keeping the machining proficiency and adding those two.

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions labels Sep 4, 2025
@mwhit030 mwhit030 marked this pull request as ready for review September 4, 2025 18:00
@mwhit030 mwhit030 marked this pull request as draft September 4, 2025 19:31
@mwhit030 mwhit030 marked this pull request as ready for review September 4, 2025 19:47
@mwhit030 mwhit030 marked this pull request as draft September 4, 2025 20:01
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 4, 2025
Copy link
Contributor

@TheShadowFerret TheShadowFerret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Machinist hobby or profession when 👀

@github-actions github-actions bot added the Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies label Sep 6, 2025
@mwhit030 mwhit030 marked this pull request as ready for review September 6, 2025 01:11
@mwhit030 mwhit030 marked this pull request as draft September 6, 2025 02:15
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 6, 2025
@mwhit030 mwhit030 marked this pull request as ready for review September 7, 2025 03:10
@Maleclypse Maleclypse merged commit 06b9488 into CleverRaven:master Sep 11, 2025
45 checks passed
@mwhit030 mwhit030 deleted the millingmach branch September 12, 2025 12:36
@mwhit030 mwhit030 restored the millingmach branch September 12, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants