refactor(injector/typed): Refactor ResolveInterfaceTypeByName for improved clarity and error handling

[kakkoyun]

This update refactors the ResolveInterfaceTypeByName function to enhance its structure and error reporting. The function now separates the logic for handling built-in types and package-qualified types, improving readability. A new helper function, validateTypeNameIsInterface, has been introduced to encapsulate the validation of interface types, ensuring consistent error messages and reducing code duplication.

Additionally, specific error messages have been added for import failures and type lookups, providing clearer context for users.

Signed-off-by: Kemal Akkoyun [email protected]

[kakkoyun]

• feat(injector/typed): Enhance type checking with additional generic type test cases #634
• feat(injector): Add ArgumentThatImplements method for argument interface matching #617
• refactor(injector/typed): Refactor ResolveInterfaceTypeByName for improved clarity and error handling #616 👈 (View in Graphite)
• refactor(injector): Refactor TypeName handling and migrate to typed package #615 : 1 other dependent PR (#633 )
• feat(injector): Add return-implements function join point #602
• feat(injector): Add ability to find function results implementing an interface #587
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 66.80%. Comparing base (b3088d9) to head (827efcf).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/injector/typed/typecheck.go	56.25%	11 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   68.49%   66.80%   -1.69%     
==========================================
  Files         113      113              
  Lines        7868     7866       -2     
==========================================
- Hits         5389     5255     -134     
- Misses       1938     2068     +130     
- Partials      541      543       +2     

Components	Coverage Δ
Generators	80.24% <ø> (ø)
Instruments	∅ <ø> (∅)
Go Driver	75.81% <ø> (-0.70%)	⬇️
Toolexec Driver	67.53% <ø> (-3.31%)	⬇️
Aspects	72.21% <ø> (-2.46%)	⬇️
Injector	73.01% <56.25%> (-1.98%)	⬇️
Job Server	68.96% <ø> (-1.08%)	⬇️
Other	66.80% <56.25%> (-1.69%)	⬇️

Files with missing lines	Coverage Δ
internal/injector/typed/typecheck.go	65.15% <56.25%> (+6.32%)	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.