feat(injector/typed): add interface-based type system with parser

[kakkoyun]

feat(injector/typed): add interface-based type system with parser

• Introduce Type interface for polymorphic type handling
• Add support for pointer, slice, array, and map types
• Implement recursive descent parser for type expressions
• Rename TypeName to NamedType for clarity
• Add helper functions NewNamedType and MustNamedType
• Update all usage sites to use new type system

perf(injector/typed): remove regex-based parsing and document improvements

Replaced regex-based type parsing with recursive descent parser:

• 71.53% faster overall (geometric mean)
• 53.15% less memory usage
• 29.26% fewer allocations

Benchmark results (old regex vs new parser):

• Simple types: 5.21x faster, 87% less memory
• Qualified types: 8.14x faster, 91% less memory
• Pointer types: 5.89x faster, 89% less memory
• Complex nested types: 7.89x faster, 92% less memory

All improvements statistically significant (p=0.008)

Signed-off-by: Kemal Akkoyun [email protected]

[kakkoyun]

• feat(injector/typed): add interface-based type system with parser #633 👈 (View in Graphite)
• refactor(injector): Refactor TypeName handling and migrate to typed package #615 : 1 other dependent PR (#616 )
• feat(injector): Add return-implements function join point #602
• feat(injector): Add ability to find function results implementing an interface #587
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[RomainMuller]

It really bothers me that it's unclear whether the types are conveyed by pointer or value... They need to be either, not both... The pointer derefs look odd and should be removed one way or the other IMHO.

[kakkoyun]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.

2025-06-05 18:20:30 UTC ℹ️ Start processing command /merge

---

2025-06-05 18:20:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2025-06-05 18:21:17 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

[kakkoyun]

/remove

[dd-devflow]

View all feedbacks in Devflow UI.

2025-06-05 18:21:12 UTC ℹ️ Start processing command /remove

---

2025-06-05 18:21:14 UTC ℹ️ Devflow: /remove

[Copilot]

Pull Request Overview

This PR introduces a comprehensive interface-based type system for the injector/typed package, replacing the previous TypeName struct with a polymorphic Type interface. The changes also include a new recursive descent parser that replaces regex-based parsing for improved performance and Unicode support.

Key changes:

• Replace TypeName struct with Type interface supporting pointer, slice, array, and map types
• Implement recursive descent parser with comprehensive Unicode support
• Rename TypeName to NamedType for clarity and add helper functions

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
internal/injector/typed/typename_test.go	Removed - replaced by new type-specific test files
internal/injector/typed/typename.go	Removed - functionality migrated to new type system files
internal/injector/typed/typed.go	New utility functions for type extraction
internal/injector/typed/type_test.go	Basic tests for new Type interface
internal/injector/typed/type.go	Core Type interface definition with comprehensive documentation
internal/injector/typed/slice_test.go	Comprehensive tests for slice type parsing and matching
internal/injector/typed/slice.go	SliceType implementation
internal/injector/typed/pointer_test.go	Tests for pointer type functionality
internal/injector/typed/pointer.go	PointerType implementation
internal/injector/typed/parser.go	New recursive descent parser with Unicode support
internal/injector/typed/parse_test.go	Extensive parser tests including Unicode handling
internal/injector/typed/namedtype_test.go	Tests for NamedType functionality
internal/injector/typed/namedtype.go	NamedType implementation with backward compatibility
internal/injector/typed/map_test.go	Tests for map type parsing and matching
internal/injector/typed/map.go	MapType implementation
internal/injector/typed/array_test.go	Tests for array type functionality
internal/injector/typed/array.go	ArrayType implementation
internal/injector/aspect/join/struct.go	Updated to use new type system
internal/injector/aspect/join/function_test.go	Updated type references
internal/injector/aspect/join/function.go	Updated to use NamedType pointers
internal/injector/aspect/join/declaration.go	Updated type usage
internal/injector/aspect/advice/struct.go	Updated to use new type system
internal/injector/aspect/advice/code/dot_function.go	Updated type matching calls
internal/injector/aspect/advice/call_test.go	Updated type references
internal/injector/aspect/advice/call.go	Updated to use new type system

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}