-
Notifications
You must be signed in to change notification settings - Fork 3
feat(core): migrate MoveHandle #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dopenguin
wants to merge
16
commits into
vue3/migrate-plugin-layer-chooser
Choose a base branch
from
vue3/migrate-core-move-handle
base: vue3/migrate-plugin-layer-chooser
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): migrate MoveHandle #360
dopenguin
wants to merge
16
commits into
vue3/migrate-plugin-layer-chooser
from
vue3/migrate-core-move-handle
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt on small devices
…nt on small devices
…re-move-handle # Conflicts: # src/plugins/iconMenu/components/NineRegionsButton.ce.vue
…re-move-handle # Conflicts: # examples/snowbox/index.js # src/plugins/iconMenu/components/NineRegionsButton.ce.vue # src/plugins/iconMenu/components/StandardMenu.ce.vue # src/plugins/iconMenu/store.ts
…re-move-handle # Conflicts: # src/core/components/PolarContainer.ce.vue # src/core/stores/export.ts # src/core/types.ts
…set to the MoveHandle
|
@oeninghe-dataport I've set the base branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate MoveHandle to display properly display content on small devices.
Instructions for local reproduction and review
The content of the LayerChooser now should be displayed in the MoveHandle.
When resizing the browser window again, the content should be displayed normally if the window becomes larger than 768px in width and vice versa.
Relevant tickets, issues, et cetera
Blocked by #357 and #358