Bump elements dep and bump version to 0.5 #97
Conversation
|
Heh, this crate was last touched 8 months ago. I will take some time today to try to get it into working shape. |
|
If you approve #98 and rebase this on that it should be good to go. |
…py lints a4ec6fb ci: fix doclinks (Andrew Poelstra) 8dd5e75 clippy: enable a bunch of casting and safety lints (Andrew Poelstra) 92fc444 ci: copy workflow and contrib/ scripts from rust-elements (Andrew Poelstra) c62e83b clippy: introduce nightly-version and fix all clippy issues with it (Andrew Poelstra) Pull request description: Should get CI passing. Then we can rebase #97. ACKs for top commit: RCasatta: utACK a4ec6fb Tree-SHA512: 078f28230466f8bac28bb2cc3071852151cc2d1f1e4b7921e2edd2cf91f668d3109130db21290afd4170f40192bcb3130cde69b3ba90cbc0a15fff3f1e8c3f5c
RCasatta
force-pushed
the
bump_elements
branch
from
60b2db3 to
5c44f39
Compare
|
Now you need to update the included Cargo-latest.lock file :). |
RCasatta
force-pushed
the
bump_elements
branch
2 times, most recently
from
ce7048b to
2f88724
Compare
Signed-off-by: Riccardo Casatta <[email protected]>
RCasatta
force-pushed
the
bump_elements
branch
from
2f88724 to
c4d17b0
Compare
|
Looks like there's an incompatibility between elements 0.25 (included by Updating |
|
Ok, nice, we can do the semver trick (this is the first time I've tried it and wasn't sure if it would work). But we need to release an elements 0.26.1 first. |
05a24ad bump version to 0.26.1 (Andrew Poelstra) 2b89d5f encode: implement Encodable and Decodable for Vec<T> (Andrew Poelstra) 45a6938 export pset::error::PsetHash (Andrew Poelstra) Pull request description: I want to do the dtolnay "semver trick" where I release 0.25.3 which re-exports most of the types and traits from 0.26. This will make migration easier for users since they could use elements 0.25 and 0.26 in the same crate and have compatible types. In particular ElementsProject/elements-miniscript#97 would compile without needing to update `simplicity` and `elements` at the same time. However, when doing this I identified some gaps in the API which make this harder than it should be. See the commit messages for detailed justifications. Also release 0.26.1 with these changes. ACKs for top commit: RCasatta: utACK 05a24ad Tree-SHA512: 447d09950586da98a1d8a13fe8dc1ce69761d2a3152b9ea243264ec874f04bc1219d42a562e0470246c266980e77d2a46d807c78ed5ca9bbcf8f4055af3ea4c6
|
Can you add a Then after that, I guess we need to add a commit which updates the But at least we can do it across multiple commits now. |
create a dummy elements env just to compile
|
in the first commit I downgraded elements to 0.25.3 and use patch in f79d75e then I upgraded simplicity and just added a dummy env to "fix" compilation, not sure how the env should be handled correctly |
No description provided.