get CI up to date; pin nightly rust version; fix some clippy lints #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2025-08/ci
branch
5 times, most recently
from
c657791 to
14211e5
Compare
Copy nightly-version from rust-elements. The next commit will use it in Github CI. I won't bother making a cronjob for it because this crate is so unused that it doesn't seem worthwhile opening constant PRs for CI updates. We will try to do this manually every several months, or add a cronjob if/when this becomes used. I added an #[allow(unused)] tag on the elementsd test crate. Maybe this trait is actually unused and should be deleted. But the elementsd tests are old and bitrotted and I'd prefer to avoid touching them for purposes of this PR. This commit also introduces a lockfile. Basically, from this commit onward I want my local CI to pass, so I am throwing in several things at once.
This introduces the rust-bitcoin-maintainer-tools CI setup, which ensures that all tool versions are pinned, tests all examples, etc. I had to tweak a couple things (replacing the list of features, renaming elementsd-tests to bitcoind-tests) but otherwise this was a straight copy/paste. We also update all our CI actions to v4 from the now-deleted v2.
Also enable a grab bag of other lints; I basically copied the giant list from rust-elements and removed the ones that seemed too annoying to fix and not very important.
|
utACK a4ec6fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should get CI passing. Then we can rebase #97.