Skip to content

feat: adding public key to the multikey signer generate keypair #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: adding public key to the multikey signer generate keypair #949

wants to merge 1 commit into from

Conversation

Dudleyneedham
Copy link
Member

Adding the public key u8a to the multikey signer generate keypair.

@Dudleyneedham Dudleyneedham requested a review from rflechtner March 6, 2025 13:33
rflechtner
rflechtner requested changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we talked about this: the MultibaseKeyPair type shouldn't be changed, instead extend the type for the return type of generateKeypair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner rflechtner requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dudleyneedham @rflechtner