Skip to content

feat: adding public key to the multikey signer generate keypair #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −2
Open

feat: adding public key to the multikey signer generate keypair #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/types/src/Signers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export type MultibasePublicKey = Pick<VerificationMethod, 'publicKeyMultibase'>
export type MultibaseSecretKey = {
secretKeyMultibase: Base58BtcMultibaseString
}
export type MultibaseKeyPair = MultibasePublicKey & MultibaseSecretKey
export type MultibaseKeyPair = MultibasePublicKey &
MultibaseSecretKey & { publicKey: Uint8Array }

export type TypedKeypair<KeyTypes extends string> = {
publicKey: Uint8Array
Expand Down
5 changes: 4 additions & 1 deletion packages/utils/src/Signers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,5 +497,8 @@ export function generateKeypair({
const keyRingPair = makeKeypairFromUri(seed.toLowerCase(), typeForKeyring)

const { secretKey, publicKey } = extractPk(keyRingPair)
return encodeMultibaseKeypair({ publicKey, secretKey, type })
return {
...encodeMultibaseKeypair({ publicKey, secretKey, type }),
publicKey,
}
}
Loading