-
Notifications
You must be signed in to change notification settings - Fork 610
fix(translator): check gateway class and do not skip listeners when gateway class is not managed by KIC #7666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ot managed by KIC
9016641
to
915a344
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7666 +/- ##
=====================================
Coverage 77.2% 77.2%
=====================================
Files 222 222
Lines 25870 25903 +33
=====================================
+ Hits 19994 20020 +26
Misses 4849 4849
- Partials 1027 1034 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-7666-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25626627e3c762ac3cc12a0637b5802126b913be
# Push it to GitHub
git push --set-upstream origin backport-7666-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.x Then, create a pull request where the |
…ateway class is not managed by KIC (#7666) * check gateway class and do not skip listeners when gateway class is not managed by KIC * update changelog * store gatewayclass into cache in gwc controller * fix comments and move gwc controller name check after getting gwc (cherry picked from commit 2562662)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.12.x release/2.12.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.12.x
# Create a new branch
git switch --create backport-7666-to-release/2.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25626627e3c762ac3cc12a0637b5802126b913be
# Push it to GitHub
git push --set-upstream origin backport-7666-to-release/2.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.12.x Then, create a pull request where the |
…not skip listeners when gateway class is not managed by KIC (#7711) * fix(translator): check gateway class and do not skip listeners when gateway class is not managed by KIC (#7666) * check gateway class and do not skip listeners when gateway class is not managed by KIC * update changelog * store gatewayclass into cache in gwc controller * fix comments and move gwc controller name check after getting gwc (cherry picked from commit 2562662) * fix changlog --------- Co-authored-by: Tao Yi <[email protected]>
…ateway class is not managed by KIC (#7666) * check gateway class and do not skip listeners when gateway class is not managed by KIC * update changelog * store gatewayclass into cache in gwc controller * fix comments and move gwc controller name check after getting gwc (cherry picked from commit 2562662)
…ateway class is not managed by KIC (#7666) * check gateway class and do not skip listeners when gateway class is not managed by KIC * update changelog * store gatewayclass into cache in gwc controller * fix comments and move gwc controller name check after getting gwc (cherry picked from commit 2562662)
…not skip listeners when gateway class is not managed by KIC (#7718) * fix(translator): check gateway class and do not skip listeners when gateway class is not managed by KIC (#7666) * check gateway class and do not skip listeners when gateway class is not managed by KIC * update changelog * store gatewayclass into cache in gwc controller * fix comments and move gwc controller name check after getting gwc (cherry picked from commit 2562662) * fix changelog
What this PR does / why we need it:
Do not skip checking certificates in gateway listeners that does not has "Programmed" condition if the
GatewayClass
is not managed by KIC. The change fixes an issue when KIC is deployed by gateway operator, certificates gets deleted when dataplane (Kong gateway) pods are changed.Which issue this PR fixes:
fixes #7660 (then also Kong/kong-operator#1769)
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR