feat(tracing): migrate to traces v1 api [KHCP-16625] #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavrajsingh2001
requested review from
kongponents-bot and
a team
as code owners
adamdehaven
reviewed
Jun 16, 2025
| }, | ||
| "peerDependencies": { | ||
| "@kong/kongponents": "9.30.0", | ||
| "@kong/sdk-konnect-js-internal": "^0.6.0", |
There was a problem hiding this comment.
question: why is this a peerDependency?
There was a problem hiding this comment.
It looks like you're just utilizing type imports from the package? If that's the case this only needs to be included in devDependencies as it will be compiled away at build time
There was a problem hiding this comment.
Yepp, just using it for types. Will remove it from peerDependencies when I open the PR on shared-ui. Will be closing this PR then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
attributesare now simple objects instead of array of object. Now in theattributesobject, key is attribute name and value is the actual value (no moreunwrapAnyValueneeded to get the actual value)Tracenow has aresource_spansfield (which is an array of spans) instead ofbatchesmergeSpansInTraceBatchestomergeSpansInTraceon account of the above removalstring→BigIntconversion before calculations@kong/sdk-konnect-js-internalas a dev dependency for using typesJira ticket: https://konghq.atlassian.net/browse/KHCP-16625