-
Notifications
You must be signed in to change notification settings - Fork 12
feat(tracing): migrate to traces v1 api [KHCP-16625] #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vaibhavrajsingh2001
wants to merge
3
commits into
main
Choose a base branch
from
feat/traces-v1-api-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{ "resource_spans": [ { "resource": { "attributes": { "service.instance.id": "adc514bd-dd1b-4d00-8d48-e9836710fe74", "service.name": "kong", "service.version": "3.10.0.1", "session.id": "01975423-1b1e-71e8-8786-f1378ef65554" } }, "scope_spans": [ { "scope": { "name": "kong-internal", "version": "0.1.0" }, "spans": [ { "attributes": { "client.address": "172.17.0.1", "client.port": 46084, "http.request.header.host": "localhost", "http.request.method": "GET", "http.request.size": 94, "http.response.size": 885, "http.response.status_code": 200, "http.route": "/mock", "network.peer.address": "172.17.0.1", "network.peer.port": 46084, "network.protocol.name": "http", "network.protocol.version": "1.1", "proxy.kong.client.keepalive": false, "proxy.kong.http.request.body.size": 0, "proxy.kong.http.response.body.size": "504", "proxy.kong.latency.3p.dns.total_io": 0.0896, "proxy.kong.latency.3p.http_client.total_io": 0, "proxy.kong.latency.3p.redis.total_io": 0, "proxy.kong.latency.3p.tcpsock.total_io": 0, "proxy.kong.latency.3p.total_io": 0.0896, "proxy.kong.latency.client": 0.8243199999999999, "proxy.kong.latency.internal": 0.008937284545908142, "proxy.kong.latency.total": 236, "proxy.kong.latency.upstream": 235.0771427154541, "proxy.kong.latency.upstream.read_body_duration": 1.2440681457519531, "proxy.kong.latency.upstream.read_headers_duration": 197.31903076171875, "proxy.kong.request.id": "87cc7f068280e205811d8c5d9af38801", "proxy.kong.route.id": "a804bd2c-39b5-4b2d-8003-353a7efa21b8", "proxy.kong.service.id": "d3f030f5-fb3b-4612-bef8-7740b25a26a2", "proxy.kong.target.id": "unknown", "proxy.kong.upstream.addr": "37.16.15.184", "proxy.kong.upstream.host": "37.16.15.184:443", "proxy.kong.upstream.id": "unknown", "proxy.kong.upstream.status_code": 200, "server.address": "172.17.0.2", "server.port": 8000, "url.full": "http://localhost:8000/mock/anything/123", "url.scheme": "http" }, "end_time_unix_nano": "1749463290256081664", "kind": "SPAN_KIND_SERVER", "name": "kong", "parent_span_id": "", "span_id": "a5b4902ca201a8e3", "start_time_unix_nano": "1749463290017999872", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "attributes": { "proxy.kong.http.request.headers.count": 3, "proxy.kong.http.request.headers.size": 59 }, "end_time_unix_nano": "1749463290018669056", "kind": "SPAN_KIND_SERVER", "name": "kong.read_client_http_headers", "parent_span_id": "a5b4902ca201a8e3", "span_id": "a2055a33fba527d7", "start_time_unix_nano": "1749463290017999872", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "trace_id": "0f83f61232782a1022a74e20c0dc7b19", "span_id": "20f0643886c583f7", "parent_span_id": "a5b4902ca201a8e3", "name": "kong.access.plugin.basic-auth", "kind": "SPAN_KIND_INTERNAL", "start_time_unix_nano": "1749463290018669058", "end_time_unix_nano": "1749463290018678058", "attributes": { "proxy.kong.plugin.id": "6c27de60-9bb4-4170-9fea-089babcb7393" }, "status": {} }, { "end_time_unix_nano": "1749463290018703104", "kind": "SPAN_KIND_INTERNAL", "name": "kong.phase.rewrite", "parent_span_id": "a5b4902ca201a8e3", "span_id": "15fc985e0074269d", "start_time_unix_nano": "1749463290018679296", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "end_time_unix_nano": "1749463290019085312", "kind": "SPAN_KIND_INTERNAL", "name": "kong.phase.access", "parent_span_id": "a5b4902ca201a8e3", "span_id": "05caed47c5a6d318", "start_time_unix_nano": "1749463290018710528", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "attributes": { "proxy.kong.route.id": "a804bd2c-39b5-4b2d-8003-353a7efa21b8", "proxy.kong.router.matched": true, "proxy.kong.router.upstream_path": "/anything", "proxy.kong.service.id": "d3f030f5-fb3b-4612-bef8-7740b25a26a2" }, "end_time_unix_nano": "1749463290018804480", "kind": "SPAN_KIND_INTERNAL", "name": "kong.router", "parent_span_id": "05caed47c5a6d318", "span_id": "2830bbaf04412bbd", "start_time_unix_nano": "1749463290018735360", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "attributes": { "proxy.kong.dns.domain": "httpbin.konghq.com", "proxy.kong.dns.tries": [ { "cache?": true, "qname": "httpbin.konghq.com", "resolver": "cache" }, { "cache?": true, "qname": "httpbin.konghq.com", "resolver": "cache", "result": [ { "ip": "37.16.15.184", "ttl": 0, "type": "A" } ], "type": "A" } ] }, "end_time_unix_nano": "1749463290019065856", "kind": "SPAN_KIND_CLIENT", "name": "kong.dns", "parent_span_id": "05caed47c5a6d318", "span_id": "61907c44efe3756c", "start_time_unix_nano": "1749463290018965504", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "attributes": { "proxy.kong.http.content_length": 0 }, "end_time_unix_nano": "1749463290019117568", "kind": "SPAN_KIND_SERVER", "name": "kong.read_client_http_body", "parent_span_id": "a5b4902ca201a8e3", "span_id": "5a04a48e5b4f317d", "start_time_unix_nano": "1749463290019084544", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "end_time_unix_nano": "1749463290253632768", "kind": "SPAN_KIND_INTERNAL", "name": "kong.phase.header_filter", "parent_span_id": "a5b4902ca201a8e3", "span_id": "3dfcecd382f5f3d0", "start_time_unix_nano": "1749463290252982784", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "end_time_unix_nano": "1749463290254194688", "kind": "SPAN_KIND_INTERNAL", "name": "kong.phase.body_filter", "parent_span_id": "a5b4902ca201a8e3", "span_id": "34dbd549af4da216", "start_time_unix_nano": "1749463290253768192", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "attributes": { "proxy.kong.upstream.id": "unknown", "proxy.kong.upstream.lb_algorithm": "unknown", "try_count": 1 }, "end_time_unix_nano": "1749463290055609088", "kind": "SPAN_KIND_CLIENT", "name": "kong.upstream.selection", "parent_span_id": "a5b4902ca201a8e3", "span_id": "270654ea06c11f6e", "start_time_unix_nano": "1749463290019095040", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "attributes": { "keepalive": true, "network.peer.address": "37.16.15.184", "network.peer.name": "httpbin.konghq.com", "network.peer.port": 443, "proxy.kong.latency.upstream.connect_duration": 36.5140438079834, "proxy.kong.target.id": "unknown", "try_count": 1 }, "end_time_unix_nano": "1749463290055609088", "kind": "SPAN_KIND_CLIENT", "name": "kong.find_upstream", "parent_span_id": "270654ea06c11f6e", "span_id": "a1ed49bb760b5fd0", "start_time_unix_nano": "1749463290019095040", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "end_time_unix_nano": "1749463290252809984", "kind": "SPAN_KIND_CLIENT", "name": "kong.send_request_to_upstream", "parent_span_id": "a5b4902ca201a8e3", "span_id": "601a923771322874", "start_time_unix_nano": "1749463290055609088", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "end_time_unix_nano": "1749463290252928000", "kind": "SPAN_KIND_CLIENT", "name": "kong.read_headers_from_upstream", "parent_span_id": "a5b4902ca201a8e3", "span_id": "e2823f352021a8f9", "start_time_unix_nano": "1749463290252809984", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "end_time_unix_nano": "1749463290254172160", "kind": "SPAN_KIND_CLIENT", "name": "kong.read_body_from_upstream", "parent_span_id": "a5b4902ca201a8e3", "span_id": "d5ffef3a4152719d", "start_time_unix_nano": "1749463290252928000", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" }, { "end_time_unix_nano": "1749463290254316800", "kind": "SPAN_KIND_SERVER", "name": "kong.wait_for_client_read", "parent_span_id": "a5b4902ca201a8e3", "span_id": "f6bc7f988a76f468", "start_time_unix_nano": "1749463290254194688", "status": {}, "trace_id": "0f83f61232782a1022a74e20c0dc7b19" } ] } ] } ] } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why is this a peerDependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're just utilizing type imports from the package? If that's the case this only needs to be included in devDependencies as it will be compiled away at build time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yepp, just using it for types. Will remove it from
peerDependencies
when I open the PR on shared-ui. Will be closing this PR then.