[WIP] Fix warnings raised by URI 1.0.1 #9307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jrafanie
force-pushed
the
fix-uri-1-0-1-warnings
branch
from
f1e35b0 to
56ed15b
Compare
|
Checked commit jrafanie@56ed15b with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
jrafanie
commented
Oct 15, 2025
| url_parm = parse_questionmark.post_match if parse_questionmark.present? | ||
| url_parm = parse_ampersand.post_match if parse_ampersand.present? | ||
| encoded_url = URI::DEFAULT_PARSER.escape(url_parm) | ||
| encoded_url = URI::RFC2396_PARSER.escape(url_parm) |
There was a problem hiding this comment.
Closing, they must have fixed/pulled/pushed 1.0.1 as the warnings are gone now in 1.0.1 and 1.0.4
irb(main):001> require 'uri'
=> true
irb(main):002> URI::DEFAULT_PARSER
=> #<URI::RFC3986_Parser:0x0000000121efb998>
irb(main):003> URI::VERSION
=> "1.0.4"
irb(main):004> URI::PATTERN::UNRESERVED
=> "\\-_.!~*'()a-zA-Z\\d"
|
Not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP:
Related to:
https://www.github.com/ruby/uri/issues/125
ManageIQ/manageiq#23260