[WIP] Fix warnings raised by URI 1.0.1 #23261
Closed
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
fix-uri-1-0-1-warnings
branch
2 times, most recently
from
1ea126b to
35bd2c9
Compare
jrafanie
changed the title
jrafanie
force-pushed
the
fix-uri-1-0-1-warnings
branch
from
733c1f4 to
e4e6169
Compare
This was referenced Nov 8, 2024
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Nov 8, 2024
From Pull Request: ManageIQ/manageiq#23261
|
ok, cross repo: ManageIQ/manageiq-cross_repo-tests#928 is green other than an issue requiring qpid_proton in nuage and openstack: @agrare Have you seen this before? |
jrafanie
force-pushed
the
fix-uri-1-0-1-warnings
branch
from
e4e6169 to
b1a2248
Compare
|
Looks like legit issues with nuage, openstack: number of args to constructor |
yeah, thanks, I was meaning to look at those again today |
I wonder if the warnings about uri 1.0.1 are an indicator it's related to 1.0.1 |
jrafanie
force-pushed
the
fix-uri-1-0-1-warnings
branch
from
b1a2248 to
8b65989
Compare
|
@jrafanie What is the impetus to upgrade to 1.0? (I noticed that the default gem in Ruby 3.3.6 is 0.13, and in Ruby 3.4.0 preview, it's also 0.13) |
We didn't previously have a version constraint on it and upgrading to 1.0 broke developers locally. There isn't a real backward compatible way to make pre-1.0 changes work without warnings in 1.0 so I was going to upgrade after backports were dying down. |
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
I added myself as a assignee to be able to find this in the future |
jrafanie
commented
Oct 16, 2025
| belongs_to :user | ||
|
|
||
| validates :url, :format => URI::DEFAULT_PARSER.make_regexp, :allow_nil => false | ||
| validates :url, :format => URI::RFC2396_PARSER.make_regexp, :allow_nil => false |
There was a problem hiding this comment.
Closing, this is no longer an issue with URI 1.0.4:
irb(main):001> require 'uri'
=> true
irb(main):002> URI::DEFAULT_PARSER
=> #<URI::RFC3986_Parser:0x0000000121efb998>
irb(main):003> URI::VERSION
=> "1.0.4"
irb(main):004> URI::PATTERN::UNRESERVED
=> "\\-_.!~*'()a-zA-Z\\d"
Will open a replacement PR to simplify this upgrade.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Oct 16, 2025
Replaces ManageIQ#23261
|
Replaced by #23630 |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Oct 16, 2025
Replaces ManageIQ#23261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP:
Use new constants- No longer neededRelated to:
https://www.github.com/ruby/uri/issues/125
#23260