Upgrade QueryRelation to leverage eager_include/preload #23620
Merged
+31
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kbrock
force-pushed
the
aaar_scope_dependency
branch
from
175d460 to
cc8438f
Compare
|
We had missed adding eager_load and references to the scope. I was feeling concerned. update:
update:
|
kbrock
force-pushed
the
aaar_scope_dependency
branch
from
cc8438f to
011d57c
Compare
Fryguy
reviewed
Oct 13, 2025
Fryguy
reviewed
Oct 13, 2025
kbrock
force-pushed
the
aaar_scope_dependency
branch
from
011d57c to
3aac4f3
Compare
Turns out for AAAS case, we currently only need to define all Rbac has already used all, so all methods go directly to the aar_scope (which an an active record scope) So all of these other methods are moot. Well, for this implementation. We do want it to be complete in case the code changes and someone decides to do something like call eager_load before calling all
kbrock
force-pushed
the
aaar_scope_dependency
branch
from
3aac4f3 to
b409771
Compare
|
update:
|
This was dropped by a18d3da
|
update:
|
Fryguy
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #23617
We can treat the 2 PRs separately (and I'll remove these commits from ^)
or we can just merge the other PR.