Add password auth support #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
requested review from
alex-hunt-materialize,
kay-kim,
def- and
jubrad
and removed request for
alex-hunt-materialize
3 tasks
def-
approved these changes
Jun 12, 2025
jubrad
reviewed
Jun 17, 2025
| balancer_cpu_request = optional(string, "100m") | ||
| license_key = optional(string) | ||
| authenticator_kind = optional(string, "None") | ||
| external_login_password_mz_system = optional(string) |
There was a problem hiding this comment.
We probably shouldn't let this be a variable here...
jubrad
approved these changes
Jun 17, 2025
| # memory_request = "4Gi" | ||
| # memory_limit = "4Gi" | ||
| # authenticator_kind = "Password" | ||
| # external_login_password_mz_system = "your-password" |
There was a problem hiding this comment.
hmm, we really shouldn't have this as an example var, because this could be made public we don't want someone to just uncomment code that could expose a system with a default password.
Maybe worth recomending:
random_password.anatlyics_mz_system
This was referenced Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on MaterializeInc/terraform-helm-materialize#47