Skip to content

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 11, 2025

Explanation

This PR introduced a change to require approvals for all Mobile hardware wallets when submitting a transaction. This PR changes that behavior to only require approval for Ledger devices, as the fix was intended for that specific hardware wallet.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mikesposito mikesposito marked this pull request as ready for review September 11, 2025 13:21
@mikesposito mikesposito requested review from a team as code owners September 11, 2025 13:21
cursor[bot]

This comment was marked as outdated.

infiniteflower
infiniteflower previously approved these changes Sep 11, 2025
@mikesposito
Copy link
Member Author

Closing as we reached consensus over another solution. See: https://consensys.slack.com/archives/C026NDN79JB/p1757506871532219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants