Skip to content

Conversation

sophieqgu
Copy link
Contributor

@sophieqgu sophieqgu commented Sep 29, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Migrates opt-in to a mobile timestamp-signed flow (EVM and Solana), adds InvalidTimestamp retry, and updates service endpoints, types, messenger, and tests.

  • Rewards opt-in flow:
    • Replace challenge-based optin with timestamp-signed mobile flow in RewardsController using #signRewardsMessage and RewardsDataService:mobileOptin.
    • Add retry on InvalidTimestampError and support both EVM and Solana signing paths.
  • Data service:
    • Add mobileOptin(body) calling /auth/mobile-optin; remove generateChallenge/optin usage for controller path.
    • Return InvalidTimestampError with server timestamp; log error payloads.
  • Types:
    • Remove GenerateChallengeDto, ChallengeResponseDto, LoginDto; add MobileOptinDto and refine MobileLoginDto.
  • Messenger:
    • Replace allowed actions generateChallenge/optin with mobileOptin.
  • Tests:
    • Update controller and service tests for mobile opt-in (EVM/Solana), timestamp retry, and token storage handling.
    • Minor fix: cast base58.decode Buffer to Uint8Array in tests.

Written by Cursor Bugbot for commit 5b9aa5c. This will update automatically on new commits. Configure here.

@sophieqgu sophieqgu requested a review from a team as a code owner September 29, 2025 20:58
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sophieqgu sophieqgu added team-rewards No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Sep 29, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

jonson
jonson previously approved these changes Sep 29, 2025
Base automatically changed from Set-max-width-to-level-up-message to main September 30, 2025 08:52
@VGR-GIT VGR-GIT dismissed jonson’s stale review September 30, 2025 08:52

The base branch was changed.

@VGR-GIT VGR-GIT force-pushed the rewards-use-mobile-optin branch from 7460bd5 to 922af55 Compare September 30, 2025 09:28
VGR-GIT
VGR-GIT previously approved these changes Sep 30, 2025
@VGR-GIT VGR-GIT changed the title Switch to mobile optin endpoint chore: switch to mobile optin endpoint Sep 30, 2025
@VGR-GIT VGR-GIT enabled auto-merge September 30, 2025 09:39
@VGR-GIT VGR-GIT added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit bb3e75e Sep 30, 2025
106 of 108 checks passed
@VGR-GIT VGR-GIT deleted the rewards-use-mobile-optin branch September 30, 2025 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-L team-rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants