-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: switch to mobile optin endpoint #20554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+412
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
jonson
previously approved these changes
Sep 29, 2025
7460bd5
to
922af55
Compare
VGR-GIT
previously approved these changes
Sep 30, 2025
d21e4e3
to
0aa5929
Compare
VGR-GIT
approved these changes
Sep 30, 2025
jbblanc
approved these changes
Sep 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No E2E Smoke Needed
If the PR does not need E2E smoke test run
No QA Needed
Apply this label when your PR does not need any QA effort.
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
release-7.57.0
Issue or pull request that will be included in release 7.57.0
size-L
team-rewards
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Migrates opt-in to a mobile timestamp-signed flow (EVM and Solana), adds InvalidTimestamp retry, and updates service endpoints, types, messenger, and tests.
optin
with timestamp-signed mobile flow inRewardsController
using#signRewardsMessage
andRewardsDataService:mobileOptin
.InvalidTimestampError
and support both EVM and Solana signing paths.mobileOptin(body)
calling/auth/mobile-optin
; removegenerateChallenge
/optin
usage for controller path.InvalidTimestampError
with server timestamp; log error payloads.GenerateChallengeDto
,ChallengeResponseDto
,LoginDto
; addMobileOptinDto
and refineMobileLoginDto
.generateChallenge
/optin
withmobileOptin
.base58.decode
Buffer toUint8Array
in tests.Written by Cursor Bugbot for commit 5b9aa5c. This will update automatically on new commits. Configure here.