Simplify unit-test logic #18071
Open
Simplify unit-test logic #18071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!ci-build-me |
glyh
commented
Nov 5, 2025
|
|
||
| echo "--- Make build" | ||
| echo "--- Make libp2p helper" | ||
| export LIBP2P_NIXLESS=1 PATH=/usr/lib/go/bin:$PATH GO=/usr/lib/go/bin/go |
Member
Author
There was a problem hiding this comment.
libp2p_helper is the only artifact that's not built on dune test invocation, hence it's suffice to do that alone here.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Stuff are being built redundantly, and a test is run multiple time.
Hence this refactor aiming at not repeating the work.
For example, rosetta unit test now only take 4min, it used to take 8min.