Skip to content

Simplify unit-test logic #18071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: compatible
Choose a base branch
from
Open

Simplify unit-test logic #18071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6e9679
unit-test.sh: remove some redundant task being ran
glyh Nov 5, 2025
d4fb48d
move print_blockchain_snark_vk into `src/lib/blockchain_snark/tests/`
glyh Nov 5, 2025
5a147d6
Don't manually trigger print_blockchain_snark_vk test in unit-test.sh
glyh Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions buildkite/scripts/unit-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,9 @@ export MINA_LIBP2P_PASS="naughty blue worm"
export NO_JS_BUILD=1 # skip some JS targets which have extra implicit dependencies
export LAGRANGE_CACHE_DIR="/tmp/lagrange-cache"

echo "--- Make build"
echo "--- Make libp2p helper"
export LIBP2P_NIXLESS=1 PATH=/usr/lib/go/bin:$PATH GO=/usr/lib/go/bin/go
Copy link
Member Author

@glyh glyh Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libp2p_helper is the only artifact that's not built on dune test invocation, hence it's suffice to do that alone here.

time make build

echo "--- Build all targets"
dune build "${path}" --profile="${profile}"

echo "--- Check for changes to verification keys"
time dune runtest "src/app/print_blockchain_snark_vk" --profile="${profile}"
time DUNE_PROFILE="${profile}" make libp2p_helper

# Turn on the proof-cache assertion, so that CI will fail if the proofs need to
# be updated.
Expand Down
0 ...pp/print_blockchain_snark_vk/.ocamlformat → ...ts/print_blockchain_snark_vk/.ocamlformat
View file
Open in desktop
File renamed without changes.
0 ...ckchain_snark_vk/blockchain_snark_vk.json → ...ckchain_snark_vk/blockchain_snark_vk.json
View file
Open in desktop
File renamed without changes.
0 src/app/print_blockchain_snark_vk/dune → ...nark/tests/print_blockchain_snark_vk/dune
View file
Open in desktop
File renamed without changes.
0 ...pp/print_blockchain_snark_vk/dune-project → ...ts/print_blockchain_snark_vk/dune-project
View file
Open in desktop
File renamed without changes.
0 ...ain_snark_vk/print_blockchain_snark_vk.ml → ...ain_snark_vk/print_blockchain_snark_vk.ml
View file
Open in desktop
File renamed without changes.