Skip to content

Conversation

@binni979
Copy link
Contributor

@binni979 binni979 commented Oct 14, 2024

This is a pull request to solve this issue.

Description of the bug:
pyQuARC does not flag the OnlineResource/Description, OnlineResource/Type, or OnlineAccess/Description fields whenever a URL is not provided. When ARC makes their recommendations, we also make recommendations for the fields above, even if a URL is not initially provided. The issue seems to be noticed with ECHO-C collections.

Findings:
While working with the fields OnlineResource/Description, OnlineResource/Type, or OnlineAccess/Description, we were using the checks url_desc_presence_check and online_resource_type_presence_check. These checks are linked to a check_id called availability_check, which is designed to accept two arguments: field_value and parent_value.

However, when I debugged the code, I noticed that our function is actually receiving only one argument, field_value. The function one_item_presence_check correctly uses just this single argument. To resolve this mismatch, I updated the rule mapping by changing the check_id from availability_check to one_item_presence_check.

To Reproduce
Example concept ID: C1627523804-LARC (echo-c)

Now, the above fields errors are seen.
Screenshot 2024-10-13 at 8 52 11 PM

@binni979 binni979 requested a review from xhagrg October 14, 2024 01:55
@binni979 binni979 self-assigned this Oct 14, 2024
@lavanya3k
Copy link
Collaborator

Describe the bug: The bug for 'Collection/OnlineResources/OnlineResource/Type' differs for the same collection ID; instead of the recommendation for the URL type, we get red flag errors.
Screenshot 2025-02-10 at 2 41 08 PM
Upon testing with the umm-c record, the schema is different than the echo-c

To Reproduce: C1627523804-LARC --format echo-c

Expected behavior: Try testing on the other collection ID with echo-c format.

@lavanya3k
Copy link
Collaborator

Try testing for OnlineAccess and OnlineResource in umm-c, and maybe echo-c (not converted to umm-c). Check for availability_check, when there are more than two or more online links or descriptions.

@FBayat021
Copy link
Collaborator

FBayat021 commented Oct 6, 2025

Tested this on G2246115850-LARC_ASDC --format echo-g. For OnlineResource/Description, it says A URL Description appears to be missing for the following URL: None. Not sure why it's flagging, but fails to reference the URL and instead inputs None

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants