-
-
Notifications
You must be signed in to change notification settings - Fork 767
Adding more options for configuring ping passthrough. #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/3.0.0
Are you sure you want to change the base?
Adding more options for configuring ping passthrough. #1519
Conversation
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
…ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]>
bc09c8e
to
d0d1d70
Compare
d0d1d70
to
71c11a8
Compare
I cleaned up my commits (specifically I removed the times I merged from upstream from the ping-passthrough-dev branch), so there is actually a reason for this new pull request now. I hope you will reevaluate my pull request in light of this. |
I've now gone through the trouble of resolving the merge conflict (so I can have an up-to-date version of Velocity build from my fork), merged ping-passthrough-dev, and tested the result. It builds, and, although I haven't thoroughly tested it, it does work. |
* preliminary cleanup of plugin message channel handling * Fix spot * Appease checkstyle * Fix tests * Add more options for ping passthrough configuration. (Merge ping-passthrough-dev) * Added 'ALLBUTVERSION' option for ping passthrough. * Trying to get the GitHub build action to run * Added more configuration options for ping passthrough. * Updated default velocity.toml * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Update proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java Co-authored-by: powercas_gamer <[email protected]> * Add support for the legacy ping passthrough. --------- Co-authored-by: TheMiningTeamYT <[email protected]> Co-authored-by: powercas_gamer <[email protected]> * Use an ImmutableList Builder * Appease checkstyle gods * Also validate length before caring to invest time into processing * Fix MinecraftChannelIdentifier parsing to align with vanilla (PaperMC#1552) * Removed legacy ping passthrough & added config migration - Bumped config-version to 2.8 - Updated comments and grammar - Removed legacy ping passthrough in the config * Cleaned up code to match code style --------- Co-authored-by: Shane Freeder <[email protected]> Co-authored-by: Loganius <[email protected]> Co-authored-by: TheMiningTeamYT <[email protected]> Co-authored-by: powercas_gamer <[email protected]> Co-authored-by: booky <[email protected]>
a31f49f
to
2c41819
Compare
When using Velocity, I have been frustrated by the lack of fine control over ping passthrough, specifically the lack of support for passing through favicons without passing through the whole ping request. I've also seen people on line asking how to pass through favicons, so I decided to add the ability to control which aspects of server list ping requests are passed through from the back end server, and which aspects aren't, through 5 new boolean configuration options in the config file.
Please don't judge my code too harshly, this is my first time writing Java, but it does compile and Checkstyle is okay with it.
(If you're wondering, yes this is a duplicate pull request -- sorry about that, I was told to make a new pull request from a different branch. However, the code has been updated since I originally opened the old pull request. Not since I closed the previous pull request though.)