fix(cohorts): fails to get chunk size in cohort calculation #40337
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavohstrassburger
added
feature/cohorts
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Changes the cohort chunking feature flag evaluation to use get_feature_flag_result instead of get_feature_flag_payload to properly check if the flag is enabled before accessing the payload. This prevents attempting to read the payload when the flag is disabled. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
gustavohstrassburger
deleted the
fix/cohort-calculation-chunking-flag-evaluation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #40260 introduced a bug as the payload from the feature flag is already a dict, not a json.
Changes
get_feature_flag_payloadtoget_feature_flag_result.How did you test this code?
It was necessary to call this in the celery task, otherwise it didn't work.