Skip to content

fix(cohorts): fails to get chunk size in cohort calculation #40337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
Merged

fix(cohorts): fails to get chunk size in cohort calculation #40337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
465b177
fix(cohorts): payload of flag is already a dict
gustavohstrassburger Oct 24, 2025
edec959
fix: typing error
gustavohstrassburger Oct 24, 2025
710d45e
fix(cohorts): use get_feature_flag_result for proper flag evaluation
gustavohstrassburger Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions posthog/models/cohort/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import json
import math
import uuid
from datetime import datetime, timedelta
Expand Down Expand Up @@ -924,7 +923,7 @@ def _get_cohort_chunking_config(
return None

try:
config_json = posthoganalytics.get_feature_flag_payload(
result = posthoganalytics.get_feature_flag_result(
"cohort-calculation-chunked",
str(team_uuid),
groups={"organization": str(organization_id)},
Expand All @@ -933,15 +932,13 @@ def _get_cohort_chunking_config(
send_feature_flag_events=False,
)

if config_json is None:
if result is None or not result.enabled or result.payload is None:
return None

config_payload = json.loads(config_json)
if config_payload and isinstance(config_payload, dict):
chunk_size = config_payload.get("chunk_size", TARGET_CHUNK_SIZE)
chunk_size = result.payload.get("chunk_size")

if isinstance(chunk_size, int) and chunk_size > 0:
return chunk_size
if isinstance(chunk_size, int) and chunk_size > 0:
return chunk_size

return TARGET_CHUNK_SIZE

Expand Down
Loading