Skip to content

Conversation

@shivanthi-amara
Copy link
Contributor

@shivanthi-amara shivanthi-amara commented Aug 25, 2025

Summary

Fixed sanity test failures related to recent changes in product or feature definitions.

Used cursor minimally, as this was straightforward refactoring

Jira

OCMUI-3657

Additional information

How to Test

Screenshot 2025-08-25 at 11 34 29 AM Screenshot 2025-08-25 at 11 41 58 AM

yarn cypress-headless --spec '/Users/lamarach/uhc-portal/cypress/e2e/rosa-hosted/RosaHostedHtpasswdAddIdentityProviders.js'

Screenshot 2025-08-25 at 2 28 27 PM

yarn cypress-headless --spec '/Users/lamarach/uhc-portal/cypress/e2e/osd-aws/OsdAwsHtpasswdAddIdentityProviders.js'

Screenshot 2025-08-25 at 1 13 22 PM

Screen Captures

Before After

Review process

Please review and follow the PR process.

QE Reviewer

  • Pre-merge testing : Verified change locally in a browser (downloaded and ran code using reviewx tool)
  • Updated/created Polarion test cases which were peer QE reviewed
  • Confirmed 'tc-approved' label was added by dev to the linked JIRA ticket
  • (optional) Updated/created Cypress e2e tests
  • Closed threads I started after the author made changes or added an explanation

@shivanthi-amara shivanthi-amara changed the title [OCMUi-3657] Fixed failures in ROSA and AWS testcases for htpasswd IDPs [OCMUI-3657] Fixed failures in ROSA and AWS testcases for htpasswd IDPs Aug 25, 2025
@shivanthi-amara
Copy link
Contributor Author

@jmekkatt @jloss-redhat kindly review this PR when you get a chance

@jmekkatt jmekkatt self-requested a review August 28, 2025 06:06
@jmekkatt
Copy link
Collaborator

Hi @shivanthi-amara , I have ran the test case OsdAwsHtpasswdAddIdentityProviders.js locally against the staging url and saw the below failure. Could you please check?
Screenshot 2025-08-28 at 12 00 08 PM

Screenshot 2025-08-28 at 11 59 50 AM

@shivanthi-amara
Copy link
Contributor Author

Hi @shivanthi-amara , I have ran the test case OsdAwsHtpasswdAddIdentityProviders.js locally against the staging url and saw the below failure. Could you please check? Screenshot 2025-08-28 at 12 00 08 PM

Screenshot 2025-08-28 at 11 59 50 AM

@jmekkatt I have tried to reproduce the error you shared earlier, but the tests run successfully on my end. Attaching screenshots for the same. Could you please try from your side?

Screenshot 2025-09-02 at 5 57 07 PM Screenshot 2025-09-02 at 6 10 30 PM

@shivanthi-amara
Copy link
Contributor Author

@jmekkatt, gentle reminder. Could you review this at your earliest convenience?

@jira-linking
Copy link

jira-linking bot commented Sep 24, 2025

Commits missing Jira IDs:
353a6fb

Copy link
Collaborator

@kdoberst kdoberst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shivanthi-amara shivanthi-amara merged commit 1b341c1 into RedHatInsights:main Sep 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants