Reset scale bounds on report change #5111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
commented
Oct 6, 2025
Comment on lines
630
to
641
| yAxisMin: $scope.yAxisSelectedItem.axisMin, | ||
| yAxisMax: $scope.yAxisSelectedItem.axisMax, | ||
| xAxisTickFormat: $scope.xAxisSelectedItem.axisTickFormat, | ||
| yAxisTickFormat: $scope.yAxisSelectedItem.axisTickFormat | ||
| }; | ||
|
|
||
| // new chartJS chart data | ||
| // yAxisVars.axisMin and axisMax are unused and will remain 'undefined'. | ||
| // They may be placeholders for future functionality. | ||
| // Leaving them undefined is ideal, as it lets Chart.js automatically determine the proper min/max values. | ||
| $scope.scatterChart.options.scales.y.min = $scope.yAxisSelectedItem.axisMin; | ||
| $scope.scatterChart.options.scales.y.max = $scope.yAxisSelectedItem.axisMax; | ||
| $scope.scatterChart.options.scales.y.type = $scope.chartData.chartData.every((d) => typeof d.y === 'number') ? 'linear' : 'category'; |
There was a problem hiding this comment.
I haven't found any code that would set .axisMin or .axisMax. But I'm leaving it in, in case I've missed something, or it's the base for future functionality. It shouldnt matter because resetting the scales to undefined fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Default report scales could get out of sync when changing between reports. Zooming in or out would set the default scales for any future report.
What's this PR do?
Resets the x & y max scale values on report change
How should this be manually tested?
Repeat the below procedure for both scatter and bar charts.
What are the relevant tickets?
#5109
Screenshots (if appropriate)