Skip to content

Reset scale bounds on report change #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Reset scale bounds on report change #5111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ccc02e
reset bounds on report change
Oct 6, 2025
9406bc6
reset bounds for bar chart
Oct 6, 2025
37a067d
Merge branch 'develop' into fix/default-report-zoom
perryr16 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions seed/static/seed/js/controllers/inventory_reports_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ angular.module('SEED.controller.inventory_reports', []).controller('inventory_re

$scope.xAxisVars consists of columns specified as numeric types.

$scope.uAxisVars consists of manually defined columns specified.
$scope.yAxisVars consists of manually defined columns specified.
Ideally, if we need to add new variables, we should just be able to add a new object to
either of these arrays. (However, at first when adding new variables we might need to add
new functionality to the directive to handle any idiosyncrasies of graphing that new variable.)
Expand Down Expand Up @@ -616,7 +616,6 @@ angular.module('SEED.controller.inventory_reports', []).controller('inventory_re
.then(
(data) => {
data = data.data;

const propertyCounts = data.property_counts;
const colorsArr = mapColors(propertyCounts);
$scope.propertyCounts = propertyCounts;
Expand All @@ -629,12 +628,16 @@ angular.module('SEED.controller.inventory_reports', []).controller('inventory_re
yAxisVarName: $scope.yAxisSelectedItem.varName,
yAxisType: $scope.yAxisSelectedItem.axisType,
yAxisMin: $scope.yAxisSelectedItem.axisMin,
yAxisMax: $scope.yAxisSelectedItem.axisMax,
xAxisTickFormat: $scope.xAxisSelectedItem.axisTickFormat,
yAxisTickFormat: $scope.yAxisSelectedItem.axisTickFormat
};

// new chartJS chart data
// yAxisVars.axisMin and axisMax are unused and will remain 'undefined'.
// They may be placeholders for future functionality.
// Leaving them undefined is ideal, as it lets Chart.js automatically determine the proper min/max values.
$scope.scatterChart.options.scales.y.min = $scope.yAxisSelectedItem.axisMin;
$scope.scatterChart.options.scales.y.max = $scope.yAxisSelectedItem.axisMax;
$scope.scatterChart.options.scales.y.type = $scope.chartData.chartData.every((d) => typeof d.y === 'number') ? 'linear' : 'category';
Comment on lines 630 to 641
Copy link
Contributor Author

@perryr16 perryr16 Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any code that would set .axisMin or .axisMax. But I'm leaving it in, in case I've missed something, or it's the base for future functionality. It shouldnt matter because resetting the scales to undefined fixes the issue.


if ($scope.chartData.chartData.every((d) => typeof d.x === 'number')) {
Expand Down Expand Up @@ -745,6 +748,10 @@ angular.module('SEED.controller.inventory_reports', []).controller('inventory_re

// new agg chart
const the_data = $scope.aggChartData.chartData;
$scope.barChart.options.scales.y.min = undefined;
$scope.barChart.options.scales.y.max = undefined;
$scope.barChart.options.scales.x.min = undefined;
$scope.barChart.options.scales.x.max = undefined;
$scope.barChart.data.labels = the_data.map((a) => a.y);
$scope.barChart.data.datasets[0].data = the_data.map((a) => a.x);
// add the colors to the datapoints, need to create a hash map first
Expand Down
Loading