Fix issue 5 #6
Open
Fix issue 5 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2017 11:36
- modify getRackAwareAssignment(): wrap body within a 'while () { try {} .. catch {}}' with a decrementing initial node capacity.
- in assignOrphans(), sort candidates by current load rather than simply an unsorted list.
- add a new test 'testClusterRebalance'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5 reported by @s905060 where a new assignment could not be generated in some cases. The issue happens because the reassignment algorithm overoptimize to avoid movement of replicas at the cost of entering a state where a replica cannot be assigned to any broker. This PR fixes the issue by retrying assignment by allowing an incrementally-increasing number of partition movement, until an assignment succeeds.