fix (unreachable?) universe bug in void map dropping logic #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-demesne
changed the title
because NooNoo told me to.
stellar-demesne
commented
Mar 8, 2025
| @@ -6623,7 +6623,7 @@ function checkVoidMap() { | |||
| if (max < game.global.world){ | |||
There was a problem hiding this comment.
I think, but am not quite fully certain, that this check will always return false; upon reaching new HZE, the game calls setVoidMaxLevel with game.global.world, so max has to be greater or equal to game.global.world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is as follows: currently, there can be a universe crossover where if you push 25 zones past your highest ever zone, it would use your u1 highest-ever-zone for the purposes of the slowdown of void maps due to progress, no matter which universe you are currently in.
There is another potential bug where this whole check is actually unreachable. i think. close examination of this entire if-block is probably reasonable. The extra indentation may be evidence that it was already somewhat discounted?
Even if it could be reached, this is a very unusual behaviour before u2z200 (where whether the game does this or not, it ceases to matter at all). Usually, pushing to a new hze is a very difficult matter, and highly encouraged to be chipped away at, at basically all points, due to the SA item contracts and scruffy's third ability and all.