Skip to content

fix (unreachable?) universe bug in void map dropping logic #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix (unreachable?) universe bug in void map dropping logic #305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9962428
fix dire (unreachable?) universe crossover bug in void map dropping l…
stellar-demesne Mar 8, 2025
2d7b40e
de-comment
stellar-demesne Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6623,7 +6623,7 @@ function checkVoidMap() {
if (max < game.global.world){
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, but am not quite fully certain, that this check will always return false; upon reaching new HZE, the game calls setVoidMaxLevel with game.global.world, so max has to be greater or equal to game.global.world.

setVoidMaxLevel(game.global.world);
if ((getLastPortal() + 25) < game.global.world)
setVoidMaxLevel(getHighestLevelCleared(false, true));
setVoidMaxLevel(getHighestLevelCleared(true, true));
}
if ((max - getLastPortal()) < 25) {
max = getLastPortal();
Expand Down Expand Up @@ -20597,4 +20597,4 @@ function keyTooltip(keyEvent, what, isItIn, event, textString, attachFunction, n

else tooltip(what, isItIn, "screenRead", ...Object.values(arguments).slice(3,))
}
}
}